[clang-format] Add ability for clang-format-diff to exit with non-0 status #70883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
✅ With the latest revision this PR passed the Python code formatter. |
owenca
reviewed
Nov 1, 2023
mydeveloperday
approved these changes
Nov 7, 2023
owenca
reviewed
Nov 8, 2023
owenca
reviewed
Nov 8, 2023
owenca
changed the title
owenca
approved these changes
Nov 9, 2023
|
Hi - would it make sense to call exit after all the diff_string is written to stdout? This allows a preview of all lines that need to change. Right now, it exits after printing out the changes needed for the first file. |
|
See #86776. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability for the clang-format-diff script to exit with a non-zero status if it detects that formatting changes are necessary. This makes it easier to use clang-format-diff as part of a DevOps pipeline, since you could add a stage to run clang-format-diff and fail if the formatting needs to be fixed.