[AMDGPU] Allow hoisting of V_CMP feeding into SI_IF and SI_IF_BREAK #71401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lowering of SI_IF and SI_IF_BREAK includes an AND with EXEC (unless it is provably not required), so compares feeding into these pseudo ops should be just as hoistable as compares feeding into explicit ANDs with EXEC.
perlfu
reviewed
Nov 8, 2023
| case AMDGPU::S_AND_SAVEEXEC_B32: | ||
| case AMDGPU::S_AND_SAVEEXEC_B64: | ||
| break; | ||
| case AMDGPU::SI_IF: | ||
| case AMDGPU::SI_IF_BREAK: | ||
| if (Use.getOperandNo() != 1) |
There was a problem hiding this comment.
Presumably this branch is specific to SI_IF_BREAK?
Could you add extra comment to explain what operand 1 is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lowering of SI_IF and SI_IF_BREAK includes an AND with EXEC (unless
it is provably not required), so compares feeding into these pseudo ops
should be just as hoistable as compares feeding into explicit ANDs with
EXEC.