Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ftynse as GitHub codeowner for MLIR Transform dialect #72882

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

ftynse
Copy link
Member

@ftynse ftynse commented Nov 20, 2023

No description provided.

Copy link
Contributor

@nicolasvasilache nicolasvasilache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Was there an RFC for this recently?

Are we looking for 1 or multiple code owners per bigger topic?

@ftynse
Copy link
Member Author

ftynse commented Nov 20, 2023

It's just a mechanism for auto-requesting code reviews, this doesn't grant any more rights. There were some PRs that I nearly missed.

@nicolasvasilache
Copy link
Contributor

It's just a mechanism for auto-requesting code reviews, this doesn't grant any more rights. There were some PRs that I nearly missed.

Ah nice, thanks! I definitely missed a bunch myself..

@nikic
Copy link
Contributor

nikic commented Nov 20, 2023

(Please do not push user branches to the upstream repo unless you want to create a stacked pull request.)

@ftynse ftynse merged commit 37fa327 into main Nov 20, 2023
3 checks passed
@ftynse ftynse deleted the users/ftynse/codeowners branch November 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants