Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSP430] Fix mayStore flag of PUSH instructions for MSP430 #73377

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Conversation

zyd2001
Copy link
Contributor

@zyd2001 zyd2001 commented Nov 25, 2023

A bug in MSP430InstrInfo.td.

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 25, 2023

@llvm/pr-subscribers-backend-msp430

Author: Yida Zhang (zyd2001)

Changes

A bug in MSP430InstrInfo.td.


Full diff: https://github.com/llvm/llvm-project/pull/73377.diff

1 Files Affected:

  • (modified) llvm/lib/Target/MSP430/MSP430InstrInfo.td (+2-1)
diff --git a/llvm/lib/Target/MSP430/MSP430InstrInfo.td b/llvm/lib/Target/MSP430/MSP430InstrInfo.td
index 0ff9763e4c93e18..714a5d4f5116554 100644
--- a/llvm/lib/Target/MSP430/MSP430InstrInfo.td
+++ b/llvm/lib/Target/MSP430/MSP430InstrInfo.td
@@ -305,12 +305,13 @@ def POP16r   : IForm16<0b0100, DstReg, SrcPostInc, 2,
   let rs = 1;
 }
 
-let mayStore = 1 in
+let mayStore = 1 in {
 def PUSH8r :  II8r<0b100, (outs), (ins GR8:$rs), "push.b\t$rs", []>;
 def PUSH16r : II16r<0b100, (outs), (ins GR16:$rs), "push\t$rs", []>;
 def PUSH16c : II16c<0b100, (outs), (ins cg16imm:$imm), "push\t$imm", []>;
 def PUSH16i : II16i<0b100, (outs), (ins i16imm:$imm), "push\t$imm", []>;
 }
+}
 
 //===----------------------------------------------------------------------===//
 // Move Instructions

@zyd2001 zyd2001 changed the title Fix mayStore flag of PUSH instructions for MSP430 [MSP430] Fix mayStore flag of PUSH instructions for MSP430 Nov 25, 2023
@asl asl merged commit 16dc557 into llvm:main Nov 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants