Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerPC] Use 'sync; ld; cmp; bc; isync' for atomic load seq-cst on 32-bit platform #75905

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

bzEq
Copy link
Collaborator

@bzEq bzEq commented Dec 19, 2023

cmp; bc; isync is more performant than lwsync theoretically.

64-bit platform already features it, now implement it for 32-bit platform.

@bzEq bzEq changed the title [PowerPC] Use 'sync; ld; cmp; bc; isync' for load seq-cst on 32-bit platform [PowerPC] Use 'sync; ld; cmp; bc; isync' for atomic load seq-cst on 32-bit platform Dec 19, 2023
Copy link
Contributor

@syzaara syzaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chenzheng1030 chenzheng1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks for impoving this.

@bzEq bzEq merged commit 5641422 into llvm:main Dec 20, 2023
4 checks passed
@bzEq bzEq deleted the atomic-32-load branch December 20, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants