Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORC-RT] Fix ptrauth signing for dlsym return value #75972

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

benlangmuir
Copy link
Collaborator

dlsym signs text symbols as functions rather than data in dyld, so match that for orc runtime dlsym. This fixes run_program on arm64e.

dlsym signs text symbols as functions rather than data in dyld, so match
that for orc runtime dlsym. This fixes run_program on arm64e.
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Ben!

@benlangmuir benlangmuir merged commit dc58f78 into llvm:main Dec 19, 2023
5 checks passed
@benlangmuir benlangmuir deleted the orcrt-ptrauth-text branch December 19, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants