Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Restrict thinlto icp IR test to little endian systems, and the compiler-rt test to three tested platforms. #76001

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

minglotus-6
Copy link
Contributor

@minglotus-6 minglotus-6 commented Dec 20, 2023

  • The IR test failed to import indirect callees on big-endian systems. The raw profiles are generated on little-endian systems. Going to require little-endian.
  • Limit the compiler-rt test to three tested platforms.

@minglotus-6 minglotus-6 changed the title Restrict thinlto icp IR test to little endian systems, and the compiler-rt test to three tested platforms. [test] Restrict thinlto icp IR test to little endian systems, and the compiler-rt test to three tested platforms. Dec 20, 2023
@minglotus-6 minglotus-6 marked this pull request as ready for review December 20, 2023 03:53
@llvmbot llvmbot added compiler-rt PGO Profile Guided Optimizations llvm:transforms labels Dec 20, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 20, 2023

@llvm/pr-subscribers-pgo

@llvm/pr-subscribers-llvm-transforms

Author: Mingming Liu (minglotus-6)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/76001.diff

2 Files Affected:

  • (modified) compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp (+2-2)
  • (modified) llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll (+1-2)
diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index a8644bdb26ea64..08efa42167e94d 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -13,6 +13,8 @@
 // - Generate ThinLTO summary file with LLVM bitcodes, and run `function-import` pass.
 // - Run `pgo-icall-prom` pass for the IR module which needs to import callees.
 
+// REQUIRES: windows || linux || darwin
+
 // This test and IR test llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
 // are complementary to each other; a compiler-rt test has better test coverage
 // on different platforms, and the IR test is less restrictive in terms of
@@ -35,8 +37,6 @@
 // specifies OS as Triple::OS::Win32
 //
 // UNSUPPORTED: target={{i.86.*windows.*}}
-// FIXME: Re-enable the test on powerpc.
-// UNSUPPORTED: powerpc-registered-target
 
 // RUN: rm -rf %t && split-file %s %t && cd %t
 
diff --git a/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll b/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
index 8ed989a85b1ee9..129788bf75d8d8 100644
--- a/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
+++ b/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
@@ -9,8 +9,7 @@
 ; The raw profiles storesd compressed function names, so profile reader should
 ; be built with zlib support to decompress them.
 ; REQUIRES: zlib
-; FIXME: Re-enable the test on powerpc.
-; UNSUPPORTED: powerpc-registered-target
+; REQUIRES: host-byteorder-little-endian
 
 ; RUN: rm -rf %t && split-file %s %t && cd %t
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler-rt llvm:transforms PGO Profile Guided Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants