[BOLT] Deduplicate equal offsets in BAT #76905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
dcci
reviewed
Jan 18, 2024
| } | ||
| if (BEBitMask) | ||
| delete BEBitMask; |
There was a problem hiding this comment.
Can you make this automatically memory managed?
There was a problem hiding this comment.
Good point. I can keep APInt uninitialized if it's not used.
| if (OutputOffset == InputOffset) | ||
| ++EqualOffsets; | ||
| else | ||
| break; |
There was a problem hiding this comment.
Do you want to stop here at the first offset that's different?
There was a problem hiding this comment.
Yes, that's by design. The idea is that if OutputOffset==InputOffset, only emit one of them. It's expected that if offsets start to diverge at some point, they're not reconverging.
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
rafaelauler
approved these changes
Jan 25, 2024
aaupov
changed the base branch from
users/aaupov/spr/main.bolt-deduplicate-equal-offsets-in-bat
to
main
aaupov
deleted the
users/aaupov/spr/bolt-deduplicate-equal-offsets-in-bat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode BRANCHENTRY bits as bitmask for deduplicated entries.
Reduces BAT section size:
Test Plan: Updated bolt/test/X86/bolt-address-translation.test