Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][NFC] remove TODO about AppProperties #79356

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Jan 24, 2024

AppProperties app;

is marked as a weak symbol in header now. One can just use &app != nullptr to check if app is defined. There is no need to define it for overlay mode.

@llvmbot llvmbot added the libc label Jan 24, 2024
@llvmbot
Copy link

llvmbot commented Jan 24, 2024

@llvm/pr-subscribers-libc

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

Changes
AppProperties app;

is marked as a weak symbol in header now. One can just use &app != nullptr to check if app is defined. There is no need to define it for overlay mode.


Full diff: https://github.com/llvm/llvm-project/pull/79356.diff

1 Files Affected:

  • (modified) libc/startup/linux/do_start.cpp (-1)
diff --git a/libc/startup/linux/do_start.cpp b/libc/startup/linux/do_start.cpp
index 10b215cdc27b7e4..55fd575f7ad0b02 100644
--- a/libc/startup/linux/do_start.cpp
+++ b/libc/startup/linux/do_start.cpp
@@ -37,7 +37,6 @@ extern uintptr_t __fini_array_end[];
 }
 
 namespace LIBC_NAMESPACE {
-// TODO: this symbol will be moved to config.linux.app
 AppProperties app;
 
 using InitCallback = void(int, char **, char **);

@SchrodingerZhu SchrodingerZhu merged commit 4a9b5aa into llvm:main Jan 24, 2024
5 checks passed
@SchrodingerZhu SchrodingerZhu deleted the libc/startup-remove-todo branch January 24, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants