Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][DWARF] Add option to specify DW_AT_comp_dir #79395

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

ayermolo
Copy link
Contributor

Added an --comp-dir-override option that overrides DW_AT_comp_dir in the unit die. This allows for llvm-bolt to be invoked from any category and still find .dwo files.

@ayermolo ayermolo changed the title [BOLT][DWARF][NFC] Add option to specify DW_AT_comp_dir. [BOLT][DWARF][NFC] Add option to specify DW_AT_comp_dir Jan 25, 2024
@ayermolo ayermolo requested a review from maksfb January 25, 2024 01:22
@ayermolo ayermolo added the BOLT label Jan 25, 2024
bolt/lib/Core/BinaryContext.cpp Outdated Show resolved Hide resolved
bolt/lib/Rewrite/DWARFRewriter.cpp Outdated Show resolved Hide resolved
bolt/test/X86/dwarf4-override-comp-dir.test Outdated Show resolved Hide resolved
@ayermolo ayermolo force-pushed the debugAddCompDirOption branch 2 times, most recently from 344ce6b to e4bee72 Compare January 25, 2024 21:35
Added an --comp-dir-override option that overrides DW_AT_comp_dir in the unit
die. This allows for llvm-bolt to be invoked from any category and still find
.dwo files.
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "[NFC]" before commit.

@ayermolo ayermolo changed the title [BOLT][DWARF][NFC] Add option to specify DW_AT_comp_dir [BOLT][DWARF] Add option to specify DW_AT_comp_dir Jan 25, 2024
@ayermolo ayermolo merged commit 7d27272 into llvm:main Jan 25, 2024
4 checks passed
@ayermolo ayermolo deleted the debugAddCompDirOption branch January 25, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants