[libc] disable epoll_pwait2 due to breakage #80051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that sys_epoll_pwait2 isn't always available, so we need to add some sort of condition to enable it. This patch disables it until that happens.
|
@llvm/pr-subscribers-libc Author: None (michaelrj-google) ChangesIt appears that sys_epoll_pwait2 isn't always available, so we need to Full diff: https://github.com/llvm/llvm-project/pull/80051.diff 1 Files Affected:
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 1764157da9a47..8a41a2e92ed9f 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -146,7 +146,8 @@ set(TARGET_LIBC_ENTRYPOINTS
# sys/epoll.h entrypoints
libc.src.sys.epoll.epoll_wait
libc.src.sys.epoll.epoll_pwait
- libc.src.sys.epoll.epoll_pwait2
+ # Need to check if pwait2 is available before providing.
+ # libc.src.sys.epoll.epoll_pwait2
# sys/mman.h entrypoints
libc.src.sys.mman.madvise
|
nickdesaulniers
approved these changes
Jan 30, 2024
|
https://man7.org/linux/man-pages/man2/epoll_wait.2.html says epoll_wait2 was added in linux 5.11. Linux 5.10 was a major LTS release from a few years ago that is still supported; it's possible that the build bot is running an old kernel version that doesn't yet support this header. If you can ssh into the build bot that this is failing on, please grab the output from |
michaelrj-google
added a commit
to michaelrj-google/llvm-project
that referenced
this pull request
Feb 1, 2024
Similar to llvm#80051. The epoll_pwait2 syscall isn't available on all target platforms, and this is causing downstream test failures. This patch disables it until it can be detected whether or not it is available.
lntue
pushed a commit
that referenced
this pull request
Feb 1, 2024
Similar to #80051. The epoll_pwait2 syscall isn't available on all target platforms, and this is causing downstream test failures. This patch disables it until it can be detected whether or not it is available.
agozillon
pushed a commit
to agozillon/llvm-project
that referenced
this pull request
Feb 5, 2024
Similar to llvm#80051. The epoll_pwait2 syscall isn't available on all target platforms, and this is causing downstream test failures. This patch disables it until it can be detected whether or not it is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that sys_epoll_pwait2 isn't always available, so we need to
add some sort of condition to enable it. This patch disables it until
that happens.