-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct lie in contract #82517
base: main
Are you sure you want to change the base?
Correct lie in contract #82517
Conversation
The method asserts when passed a null pointer.
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-llvm-ir Author: Dave Abrahams (dabrahams) ChangesThe method asserts when passed a null pointer. Full diff: https://github.com/llvm/llvm-project/pull/82517.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/GlobalVariable.h b/llvm/include/llvm/IR/GlobalVariable.h
index bcaf8e91432ba9..d76db8463c9dfa 100644
--- a/llvm/include/llvm/IR/GlobalVariable.h
+++ b/llvm/include/llvm/IR/GlobalVariable.h
@@ -146,8 +146,8 @@ class GlobalVariable : public GlobalObject, public ilist_node<GlobalVariable> {
assert(hasInitializer() && "GV doesn't have initializer!");
return static_cast<Constant*>(Op<0>().get());
}
- /// setInitializer - Sets the initializer for this global variable, removing
- /// any existing initializer if InitVal==NULL. If this GV has type T*, the
+ /// setInitializer - Sets the initializer for this global variable to
+ /// InitVal, which must be non-null. If this GV has type T*, the
/// initializer must have type T.
void setInitializer(Constant *InitVal);
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Ping I don't understand the CI failure I'm seeing and thus I don't know how to address it. Thanks! |
The method asserts when passed a null pointer.