Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct lie in contract #82517

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Correct lie in contract #82517

wants to merge 2 commits into from

Conversation

dabrahams
Copy link
Contributor

The method asserts when passed a null pointer.

The method asserts when passed a null pointer.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 21, 2024

@llvm/pr-subscribers-llvm-ir

Author: Dave Abrahams (dabrahams)

Changes

The method asserts when passed a null pointer.


Full diff: https://github.com/llvm/llvm-project/pull/82517.diff

1 Files Affected:

  • (modified) llvm/include/llvm/IR/GlobalVariable.h (+2-2)
diff --git a/llvm/include/llvm/IR/GlobalVariable.h b/llvm/include/llvm/IR/GlobalVariable.h
index bcaf8e91432ba9..d76db8463c9dfa 100644
--- a/llvm/include/llvm/IR/GlobalVariable.h
+++ b/llvm/include/llvm/IR/GlobalVariable.h
@@ -146,8 +146,8 @@ class GlobalVariable : public GlobalObject, public ilist_node<GlobalVariable> {
     assert(hasInitializer() && "GV doesn't have initializer!");
     return static_cast<Constant*>(Op<0>().get());
   }
-  /// setInitializer - Sets the initializer for this global variable, removing
-  /// any existing initializer if InitVal==NULL.  If this GV has type T*, the
+  /// setInitializer - Sets the initializer for this global variable to 
+  /// InitVal, which must be non-null.  If this GV has type T*, the
   /// initializer must have type T.
   void setInitializer(Constant *InitVal);
 

Copy link

github-actions bot commented Feb 21, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

dabrahams added a commit to hylo-lang/Swifty-LLVM that referenced this pull request Feb 21, 2024
@dabrahams
Copy link
Contributor Author

Ping

I don't understand the CI failure I'm seeing and thus I don't know how to address it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants