Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DirectX] disable experimental debuginfo iterators in debug-info test #86538

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

bogner
Copy link
Contributor

@bogner bogner commented Mar 25, 2024

We'll need to address this differently long term, but for now just revert to the old behaviour to keep this test from failing.

Fixes #85884

We'll need to address this differently long term, but for now just
revert to the old behaviour to keep this test from failing.

Fixes llvm#85884
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 25, 2024

@llvm/pr-subscribers-backend-directx

Author: Justin Bogner (bogner)

Changes

We'll need to address this differently long term, but for now just revert to the old behaviour to keep this test from failing.

Fixes #85884


Full diff: https://github.com/llvm/llvm-project/pull/86538.diff

1 Files Affected:

  • (modified) llvm/test/tools/dxil-dis/debug-info.ll (+1-1)
diff --git a/llvm/test/tools/dxil-dis/debug-info.ll b/llvm/test/tools/dxil-dis/debug-info.ll
index 92dc65481e825f..96e023338e5c26 100644
--- a/llvm/test/tools/dxil-dis/debug-info.ll
+++ b/llvm/test/tools/dxil-dis/debug-info.ll
@@ -1,4 +1,4 @@
-; RUN: llc --filetype=obj %s -o - | dxil-dis -o - | FileCheck %s
+; RUN: llc --filetype=obj %s -o  - -experimental-debuginfo-iterators=false | dxil-dis -o - | FileCheck %s
 target triple = "dxil-unknown-shadermodel6.7-library"
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
 

Copy link

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Contributor

@coopp coopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bogner bogner merged commit 6ac5410 into llvm:main Mar 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DirectX] dxil-dis/debug-info.ll test failing after recent debug info migration changes
4 participants