[Libomptarget] Rework Record & Replay to be a plugin member #88928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
requested review from
ggeorgakoudis,
jdoerfert,
koparasy,
Meinersbur and
shiltian
koparasy
requested changes
Apr 16, 2024
openmp/libomptarget/plugins-nextgen/common/include/PluginInterface.h
Outdated
Show resolved
Hide resolved
jhuber6
force-pushed
the
RecordAndReplay
branch
2 times, most recently
from
a30737a
to
8b721d7
Compare
ggeorgakoudis
requested changes
Apr 16, 2024
openmp/libomptarget/plugins-nextgen/common/include/PluginInterface.h
Outdated
Show resolved
Hide resolved
Summary: Previously, the R&R support was global state initialized by a global constructor. This is bad because it prevents us from adequately constraining the lifetime of the library. Additionally, we want to minimize the amount of global state floating around. This patch moves the R&R support into a plugin member like everything else. This means there will be multiple copies of the R&R implementation floating around, but this was already the case given the fact that we currently handle everything with dynamic libraries.
jhuber6
force-pushed
the
RecordAndReplay
branch
from
8b721d7
to
9316d86
Compare
ggeorgakoudis
approved these changes
Apr 16, 2024
|
This apparently broke all our buildbots, example: https://lab.llvm.org/buildbot/#/builders/193/builds/50201 |
jplehr
added a commit
that referenced
this pull request
Apr 17, 2024
…89028) Reverts #88928 This broke the AMDGPU buildbots: https://lab.llvm.org/buildbot/#/builders/193/builds/50201 https://lab.llvm.org/staging/#/builders/185/builds/5565 https://lab.llvm.org/buildbot/#/builders/259/builds/2955
jhuber6
added a commit
to jhuber6/llvm-project
that referenced
this pull request
Apr 17, 2024
Summary: Previously, the R&R support was global state initialized by a global constructor. This is bad because it prevents us from adequately constraining the lifetime of the library. Additionally, we want to minimize the amount of global state floating around. This patch moves the R&R support into a plugin member like everything else. This means there will be multiple copies of the R&R implementation floating around, but this was already the case given the fact that we currently handle everything with dynamic libraries.
jhuber6
added a commit
to jhuber6/llvm-project
that referenced
this pull request
Apr 17, 2024
Summary: Previously, the R&R support was global state initialized by a global constructor. This is bad because it prevents us from adequately constraining the lifetime of the library. Additionally, we want to minimize the amount of global state floating around. This patch moves the R&R support into a plugin member like everything else. This means there will be multiple copies of the R&R implementation floating around, but this was already the case given the fact that we currently handle everything with dynamic libraries.
jhuber6
added a commit
that referenced
this pull request
May 16, 2024
…89097) Summary: Previously, the R&R support was global state initialized by a global constructor. This is bad because it prevents us from adequately constraining the lifetime of the library. Additionally, we want to minimize the amount of global state floating around. This patch moves the R&R support into a plugin member like everything else. This means there will be multiple copies of the R&R implementation floating around, but this was already the case given the fact that we currently handle everything with dynamic libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the R&R support was global state initialized by a global
constructor. This is bad because it prevents us from adequately
constraining the lifetime of the library. Additionally, we want to
minimize the amount of global state floating around.
This patch moves the R&R support into a plugin member like everything
else. This means there will be multiple copies of the R&R implementation
floating around, but this was already the case given the fact that we
currently handle everything with dynamic libraries.