Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR] Update doc comment in ViewLikeInterface.td (NFC) #89074

Merged

Conversation

abdulraheembeigh
Copy link
Contributor

@abdulraheembeigh abdulraheembeigh commented Apr 17, 2024

Signed-off: Abdul Raheem Beigh abdulraheembeigh@gmail.com

-- Update doc comment for getMixedOffsets API in  ViewLikeInterface.td

Signed-off: Abdul Raheem Beigh <abdulraheembeigh@gmail.com>
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the mlir label Apr 17, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 17, 2024

@llvm/pr-subscribers-mlir

Author: Abdul Raheem (abdulraheembeigh)

Changes

-- Update doc comment for getMixedOffsets API in ViewLikeInterface.td

Signed-off: Abdul Raheem Beigh <abdulraheembeigh@gmail.com>


Full diff: https://github.com/llvm/llvm-project/pull/89074.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Interfaces/ViewLikeInterface.td (+1-1)
diff --git a/mlir/include/mlir/Interfaces/ViewLikeInterface.td b/mlir/include/mlir/Interfaces/ViewLikeInterface.td
index ea5bb1b5ac4853..9397f271e1bc62 100644
--- a/mlir/include/mlir/Interfaces/ViewLikeInterface.td
+++ b/mlir/include/mlir/Interfaces/ViewLikeInterface.td
@@ -158,7 +158,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
     >,
     InterfaceMethod<
       /*desc=*/[{
-        Return a vector of all the static or dynamic sizes of the op.
+        Return a vector of all the static or dynamic offsets of the op.
       }],
       /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult, 4>",
       /*methodName=*/"getMixedOffsets",

@abdulraheembeigh
Copy link
Contributor Author

Hi @AaronBallman Can you please review this PR?

@joker-eph joker-eph changed the title [NFC] Update doc comment in ViewLikeInterface.td [MLIR] Update doc comment in ViewLikeInterface.td (NFC) Apr 17, 2024
@joker-eph joker-eph merged commit 693a458 into llvm:main Apr 17, 2024
3 of 4 checks passed
Copy link

@abdulraheembeigh Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants