[libc] adding linux SYS_fchmodat2 syscall. #89819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: David CARLIER (devnexen) ChangesFull diff: https://github.com/llvm/llvm-project/pull/89819.diff 1 Files Affected:
diff --git a/libc/config/linux/syscall_numbers.h.inc b/libc/config/linux/syscall_numbers.h.inc
index 9f910c5f9042a8..4a19d9a08875e8 100644
--- a/libc/config/linux/syscall_numbers.h.inc
+++ b/libc/config/linux/syscall_numbers.h.inc
@@ -338,6 +338,10 @@
#define SYS_fchmodat __NR_fchmodat
#endif
+#ifdef __NR_fchmodat2
+#define SYS_fchmodat2 __NR_fchmodat2
+#endif
+
#ifdef __NR_fchown
#define SYS_fchown __NR_fchown
#endif
|
devnexen
force-pushed
the
libc_linux_sycall_fchmodat2
branch
from
983b70e
to
eaa29ad
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
libc/src/sys/stat/linux/chmod.cpp
Outdated
| #elif defined(SYS_fchmodat) | ||
| int ret = | ||
| LIBC_NAMESPACE::syscall_impl<int>(SYS_fchmodat, AT_FDCWD, path, mode); | ||
| LIBC_NAMESPACE::syscall_impl<int>(SYS_fchmodat, AT_FDCWD, path, mode, 0); | ||
| #else | ||
| #error "chmod and fchmodat syscalls not available." |
There was a problem hiding this comment.
nit: add fchmodat2 to this list
devnexen
force-pushed
the
libc_linux_sycall_fchmodat2
branch
from
eaa29ad
to
5a9be67
Compare
SYS_fchmodat2 syscall had been available since Linux 6.6, being more flexible than SYS_fchmodat to support AT_SYMLINK_NOFOLLOW.
devnexen
force-pushed
the
libc_linux_sycall_fchmodat2
branch
from
5a9be67
to
ad5461d
Compare
michaelrj-google
approved these changes
Apr 23, 2024
|
No worries I m. member ;) thx for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.