Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Fix symbol handling in critical/sections constructs #90671

Merged
merged 1 commit into from
May 6, 2024

Conversation

luporl
Copy link
Contributor

@luporl luporl commented Apr 30, 2024

Fixes #78936

@luporl
Copy link
Contributor Author

luporl commented Apr 30, 2024

Missing tests. It would probably be better to fix sections in the same PR too.

@luporl luporl changed the title [flang][OpenMP] Fix symbol handling in critical constructs [flang][OpenMP] Fix symbol handling in critical/sections constructs May 3, 2024
@luporl
Copy link
Contributor Author

luporl commented May 3, 2024

Tests added, sections construct fixed.

@luporl luporl marked this pull request as ready for review May 3, 2024 21:32
Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@luporl
Copy link
Contributor Author

luporl commented May 6, 2024

Thanks for the quick review @kiranchandramohan.

@luporl luporl merged commit e365ac8 into llvm:main May 6, 2024
6 checks passed
@luporl luporl deleted the luporl-critical-fix branch May 6, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants