Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistake in file.cpp #91192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix spelling mistake in file.cpp #91192

wants to merge 3 commits into from

Conversation

iBlanket
Copy link

@iBlanket iBlanket commented May 6, 2024

No description provided.

Copy link

github-actions bot commented May 6, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the libc label May 6, 2024
@llvmbot
Copy link

llvmbot commented May 6, 2024

@llvm/pr-subscribers-libc

Author: Joshua (iBlanket)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/91192.diff

1 Files Affected:

  • (modified) libc/src/__support/File/file.cpp (+1-1)
diff --git a/libc/src/__support/File/file.cpp b/libc/src/__support/File/file.cpp
index 58097d017a23f3..0f60a65314f1c5 100644
--- a/libc/src/__support/File/file.cpp
+++ b/libc/src/__support/File/file.cpp
@@ -356,7 +356,7 @@ int File::set_buffer(void *buffer, size_t size, int buffer_mode) {
     // We exclude the case of buffer_mode == _IONBF in this branch
     // because we don't need to allocate buffer in such a case.
     if (own_buf) {
-      // This is one of the places where use a C allocation functon
+      // This is one of the places where a C allocation functon is used
       // as C++ does not have an equivalent of realloc.
       buf = reinterpret_cast<uint8_t *>(realloc(buf, size));
       if (buf == nullptr)

@@ -356,7 +356,7 @@ int File::set_buffer(void *buffer, size_t size, int buffer_mode) {
// We exclude the case of buffer_mode == _IONBF in this branch
// because we don't need to allocate buffer in such a case.
if (own_buf) {
// This is one of the places where use a C allocation functon
// This is one of the places where a C allocation functon is used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allocation function

@SchrodingerZhu
Copy link
Contributor

@iBlanket seems that the fix for function is not pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants