[BOLT][NFC] Simplify CFG validation

[urnathan]

I noticed this Valid local had one use, whereas the rest of the function just directly returned false on failure

[llvmbot]

@llvm/pr-subscribers-bolt

Author: Nathan Sidwell (urnathan)

Changes

I noticed this Valid local had one use, whereas the rest of the function just directly returned false on failure

---

Full diff: https://github.com/llvm/llvm-project/pull/91977.diff

1 Files Affected:

• (modified) bolt/lib/Core/BinaryFunction.cpp (+3-6)

diff --git a/bolt/lib/Core/BinaryFunction.cpp b/bolt/lib/Core/BinaryFunction.cpp
index de34421ebeb08..4f44ba0d970c0 100644
--- a/bolt/lib/Core/BinaryFunction.cpp
+++ b/bolt/lib/Core/BinaryFunction.cpp
@@ -3252,12 +3252,9 @@ bool BinaryFunction::validateCFG() const {
   if (CurrentState == State::CFG_Finalized)
     return true;
 
-  bool Valid = true;
   for (BinaryBasicBlock *BB : BasicBlocks)
-    Valid &= BB->validateSuccessorInvariants();
-
-  if (!Valid)
-    return Valid;
+    if (!BB->validateSuccessorInvariants())
+      return false;
 
   // Make sure all blocks in CFG are valid.
   auto validateBlock = [this](const BinaryBasicBlock *BB, StringRef Desc) {
@@ -3326,7 +3323,7 @@ bool BinaryFunction::validateCFG() const {
     }
   }
 
-  return Valid;
+  return true;
 }
 
 void BinaryFunction::fixBranches() {