[SelectionDAG] Use ZERO_EXTEND_VECTOR_INREG for vectors

[AreaZR]

No description provided.

[llvmbot]

@llvm/pr-subscribers-llvm-selectiondag

Author: AtariDreams (AtariDreams)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/92048.diff

1 Files Affected:

• (modified) llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp (+1-2)

diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
index 0aa36deda79dc..2a8794e46e988 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
@@ -1508,8 +1508,7 @@ SDValue DAGTypeLegalizer::PromoteIntRes_VPFunnelShift(SDNode *N) {
       !TLI.isOperationLegalOrCustom(Opcode, VT)) {
     SDValue HiShift = DAG.getConstant(OldBits, DL, VT);
     Hi = DAG.getNode(ISD::VP_SHL, DL, VT, Hi, HiShift, Mask, EVL);
-    // FIXME: Replace it by vp operations.
-    Lo = DAG.getZeroExtendInReg(Lo, DL, OldVT);
+    Lo = DAG.getNode(ISD::ZERO_EXTEND_VECTOR_INREG, DL, VT, Lo);
     SDValue Res = DAG.getNode(ISD::VP_OR, DL, VT, Hi, Lo, Mask, EVL);
     Res = DAG.getNode(IsFSHR ? ISD::VP_LSHR : ISD::VP_SHL, DL, VT, Res, Amt,
                       Mask, EVL);

[arsenm]

Needs test

[RKSimon]

I don't think this can be correct - we've already extended Lo with GetPromotedInteger above, getZeroExtendInReg is just used to mask the lower bits.

[topperc]

It isn't correct and this isn't a VP instruction so wouldn't address the FIXME. The FIXME was saying we should use ISD::VP_AND instead of ISD::AND

[topperc]

I don't think this code path is exercised. I put an assert(0) in it and nothing failed.

[topperc]

I don't think this code path is exercised. I put an assert(0) in it and nothing failed.

New test coverage e417e61532ac373e7b0708262dedefcdaf6ced9c