Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Make vsetvli in test not loop invariant. NFC #92094

Merged
merged 1 commit into from
May 15, 2024

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented May 14, 2024

The middle end will remove the inner vsetvli otherwise, and it's more typical to set the AVL to the remaining VL.

This also prevents the test from showing up as a regression in #91319

@lukel97 lukel97 requested a review from topperc May 14, 2024 10:20
Copy link
Collaborator

@preames preames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The middle end will remove the inner vsetvli otherwise, and it's more typical to set the AVL to the remaining VL.

This also prevents the test from showing up as a regression in llvm#91319
@lukel97 lukel97 force-pushed the vsetvli-insert-fix-li-test branch from 83e5fb6 to e81c3fc Compare May 15, 2024 03:48
@lukel97 lukel97 merged commit 77047e3 into llvm:main May 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants