[RemoveDIs][NFC] Fix rotten green C API test #92362
Conversation
There was a problem hiding this comment.
General comment: in some places you use mode but in others you use format.
I would suggest to have consistent terms and options, based on the format term:
new debuginfo format.
--test-dibuilder-debuginfo-new-format
--test-dibuilder-debuginfo-old-format
debug_info_new_format.ll
llvm/tools/llvm-c-test/debuginfo.c
Outdated
| @@ -215,10 +215,26 @@ int llvm_test_dibuilder(bool NewDebugInfoFormat) { | |||
|
|
|||
| LLVMDIBuilderFinalize(DIB); | |||
|
|
|||
| // In the new debug mode, debug records get attached to instructions. | |||
There was a problem hiding this comment.
Is this code depending on the given NewDebugInfoFormat?
There was a problem hiding this comment.
I thought it'd be better to minimise the difference between the tests. Adding the instructions into the old-format test doesn't hurt it IMO. In a future patch I will possibly be adding some NewDebugInfoFormat-specific behaviour, but I think minimising the difference is still worthwhile. What do you think?
|
Thanks both |
…085055ecb Local branch amd-gfx 3ae0850 Merged main:ba2e4fe4e7f79e49fcac54ea20f5b899dc687cfc into amd-gfx:c19a0f2d1e97 Remote branch main 9112073 [RemoveDIs][NFC] Fix rotten green C API test (llvm#92362)
llvm_test_dibuilder(/*NewDebugInfoMode=*/true)isn't currently executed inreturn llvm_test_dibuilder(false) && llvm_test_dibuilder(true);because
llvm_test_dibuilderreturns 0 for success.Split the llvm-c-test flag
--test-dibuilderinto two, one for the old andone for the new debug informat. Add another lit test for the new mode.
Now that the test actually runs, it crashes using the new format with
llvm/lib/IR/LLVMContextImpl.cpp:53:llvm::LLVMContextImpl::~LLVMContextImpl(): Assertion 'TrailingDbgRecords.empty() && "DbgRecords in blocks not cleaned"' failed. Aborted.Insert terminators into the blocks so that we don't leave the debug records
trailing, unattached to any instructions, which fixes that.