Add a requires lto instrprof-gc-sections.c
#92919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test has a run with `flto` so makes sense to require `lto` in some way. Currently it relies on requires `lld-available` to imply that `lto` is supported, but it would help to separate the two notions in that `lto` should require up to date components while `lld-available` may not: llvm#92752
jvoung
force-pushed
the
clang_lto_profgen_tests
branch
from
04baf87
to
c4e3e83
Compare
|
@llvm/pr-subscribers-pgo Author: Jan Voung (jvoung) ChangesThe test has a run with Full diff: https://github.com/llvm/llvm-project/pull/92919.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/instrprof-gc-sections.c b/compiler-rt/test/profile/instrprof-gc-sections.c
index 8b84c0a242180..1a772a296de82 100644
--- a/compiler-rt/test/profile/instrprof-gc-sections.c
+++ b/compiler-rt/test/profile/instrprof-gc-sections.c
@@ -1,4 +1,4 @@
-// REQUIRES: linux, lld-available
+// REQUIRES: linux, lld-available, lto
// FIXME: Investigate and fix.
// XFAIL: powerpc64-target-arch
|
|
@vitalybuka or @MaskRay if #92752 makes sense then this is a follow up. Thanks in advance. |
|
The linker tests have to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has a run with
fltoso it makes sense to requireltoin some way. Currently it relies on requireslld-availableto imply thatltois supported, but it would help to separate the two notions in thatltoshould require up to date components (#92752) whilelld-availablemay not.