Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][logo] add MLIR Sparsifier GIF assets to website #166

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

aartbik
Copy link
Contributor

@aartbik aartbik commented Jan 5, 2024

Logos for the MLIR Sparsifier project, combining the MLIR logo with the concept of a sparse tensor.

Credit:
these beautiful MLIR Sparsifier GIF logos were designed by Yinying Li

Logos for the MLIR Sparsifier project, combining the MLIR logo with
the concept of a sparse tensor.

Credit:
this beautiful MLIR Sparsifier GIF logos were designed by Yinying Li
@yinying-lisa-li
Copy link

Thanks Aart!

@joker-eph
Copy link
Contributor

Is there a license?

@aartbik
Copy link
Contributor Author

aartbik commented Jan 5, 2024

Is there a license?

Was there a license for the original MLIR logos? If so, we can release these under the same (assuming that is okay).

@aartbik
Copy link
Contributor Author

aartbik commented Jan 5, 2024

@jpienaar to comment on licensing

@jpienaar
Copy link
Member

jpienaar commented Jan 5, 2024

#132 is an ongoing discussion on making it clearer.

Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where it should go, e.g., the LogoAssets/logo is for the MLIR logo, I wonder if for subprojects it may make sense in LogoAssets/ instead (else folks could think its just the gif file format variant of the logo)

@aartbik
Copy link
Contributor Author

aartbik commented Jan 5, 2024

I wonder where it should go, e.g., the LogoAssets/logo is for the MLIR logo, I wonder if for subprojects it may make sense in LogoAssets/ instead (else folks could think its just the gif file format variant of the logo)

Yeah, good question. I tried to address this by using the extra /sparsifier level (I had to add the GIF top level since we were the first to provide a GIF logo). If you think LogoAssets/Sparsifier/GIF is better, happy to move it.

@joker-eph
Copy link
Contributor

LogoAssets/Sparsifier/GIF seems better for me. I suspect the author of the logo needs to transfer the copyright to the LLVM foundation? I don't know if a comment here is enough for this or what.

@yinying-lisa-li
Copy link

No problem! I'm happy to transfer the copyright to the LLVM foundation. Please feel free to let me know if there's anything else you need.

to make it clear this is a subproject. Below that
we follow the same file type convention and thus
use GIF for these moving logos.
@aartbik
Copy link
Contributor Author

aartbik commented Jan 5, 2024

Moved the assets into static/LogoAssets/Sparsifier/ to make it more clear this is a subproject. Below that we follow the same convention to use file types, so that gives static/LogoAssets/Sparsifier/GIF for these logos.

@yinying-lisa-li thank you again for this beautiful artwork and your verbal transfer of copyright to LLVM foundation.

@aartbik
Copy link
Contributor Author

aartbik commented Jan 9, 2024

Can we proceed with this PR, or do we need a full resolution of #132 first?

@joker-eph joker-eph merged commit 67bdf7a into llvm:main Jan 11, 2024
1 check passed
@aartbik aartbik deleted the bik branch January 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants