-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLIR][ONNX] Add OnnxToTorch support for ReduceSumSquare Op #3188
[MLIR][ONNX] Add OnnxToTorch support for ReduceSumSquare Op #3188
Conversation
@archana-ramalingam Please clang-format your code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either you can remove this test if its support is not present or add the valid checks. A lit test without any failure or check is not useful. The rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a small change, everything else looks fine.
@archana-ramalingam please rebase your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archana-ramalingam, It seems the rebasing is not done properly, I see a lot of code changes not done by you in this PR. Please correct this.
The latest llvm:main wasn't merged into this branch. Now it's fixed. |
The PR is still not rebased properly. I see |
For this particular conflict, I moved reducelogsum to a different position as both reducesumsquare and reducelogsum were written in the same lines. As you can see I am not adding reducelogsum only moving it alphabetically. |
This commit adds the OnnxToTorch support for ReduceSumSquare ops.