[LINALG] Broadcast values to shape of slize in index_put
#3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
force-pushed
the
broadcast-values
branch
from
3e0457f
to
5c8f84d
Compare
ramiro050
commented
Jun 21, 2024
|
Ready for review? Bots show some failures. |
ramiro050
force-pushed
the
broadcast-values
branch
2 times, most recently
from
51614d1
to
a76c6fc
Compare
|
@aartbik, ready! |
aartbik
approved these changes
Jun 26, 2024
The `index_put` operation, `input[indices] = values`, allows for the values to be any shape that is broadcastable to the slice `input[indices]`. This commit adds broadcasting support to the Linalg lowering of `IndexPutHackedTwinOp`.
ramiro050
force-pushed
the
broadcast-values
branch
from
a76c6fc
to
e5e7f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
index_putoperation,input[indices] = values, allows for the values to be any shape that is broadcastable to the sliceinput[indices]. This commit adds broadcasting support to the Linalg lowering ofIndexPutHackedTwinOp.Fixes: #3465