-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torch-mlir] bump to llvm/llvm-project@9b78ddf3b2abfb3e #3491
Conversation
@aartbik @PeimingLiu is there any progress on this bump? Do you need someone to pick it up? |
Yes, please! I can not reproduce the error locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. retriggered CI. Looked like maybe infra flake.
Not an infra issue but some crash in the TOSA test suite. Darn - will require triage. |
Narrowed down to ViewDynamicExpandCollapseWithParallelUnknownDimModule_basic emitting an error. A new assert was added in LLVM to ensure all errors were handled. |
Debugging instructions:
Native and Python stack:
Isolated to some faulty pass error handling code fouling things up. I think this is masking a legitimate bug, but it was causing a test that was supposed to just be XFAIL to crash the test framework on a native assert. Added a Python level WAR until I can land a proper fix upstream (which will just issue a warning when diagnostics were dropped). |
Thanks for your help with this! |
This bump triggered an upstream assert. Includes a WAR for #3506.
Also includes several things I needed to do to repro: