-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torch] Add OnnxToTorch lowering for Onnx.STFT op #3492
Conversation
156657a
to
9bfb230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, there are too many control flow paths many of which can be combined with slight modifications, please do it wherever possible to make the flow simpler.
7749f2b
to
8969e76
Compare
Hi @vivekkhandelwal1, sorry for so many control flow paths. I have fixed all the readabiity issues, and in the I apologize for the rebase, it was necessary to resolve the merge conflicts. Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the minor comments, then the PR is ready to go.
@vivekkhandelwal1 all comments have been addressed in the latest commit. Thanks for the review! |
Adds OnnxToTorch lowering for
Onnx.STFT
op.