[torch] Add OnnxToTorch lowering for Onnx.STFT op #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakdsci
force-pushed
the
stft-op-impl
branch
from
156657a
to
9bfb230
Compare
vivekkhandelwal1
requested changes
Jun 25, 2024
vinayakdsci
force-pushed
the
stft-op-impl
branch
from
7749f2b
to
8969e76
Compare
|
Hi @vivekkhandelwal1, sorry for so many control flow paths. I have fixed all the readabiity issues, and in the I apologize for the rebase, it was necessary to resolve the merge conflicts. Thanks for the review! |
vivekkhandelwal1
requested changes
Jun 25, 2024
|
@vivekkhandelwal1 all comments have been addressed in the latest commit. Thanks for the review! |
vivekkhandelwal1
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OnnxToTorch lowering for
Onnx.STFTop.