Add random events #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random events are taken from the 5 json files created by `seed.mjs`, squashed into a single json file, and extracted to lib\collections\randomEvents.json
still WIP, mappings need to be done
Couple of problems: 1. Navbar issues 2. Pages don't load (404) 3. Mapping isn't done yet
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request introduces 10 alerts when merging b2ca528 into 961fd4e - view on LGTM.com new alerts:
|
|
Forgot to add that this is just a draft PR: there are tons of random comments and unused imports in the code. |
|
This pull request introduces 10 alerts when merging fbb3ab6 into 998a613 - view on LGTM.com new alerts:
|
|
This pull request introduces 10 alerts when merging 10fefb0 into 998a613 - view on LGTM.com new alerts:
|
|
The list of random events is displayed correctly now and the 404 is fixed. |
This was referenced Aug 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navbar errors are present, presumably because terms are missing in
SiteTermMap.jsonPages for individual random events don't load (404): I tried to work off what I saw on the buildings pages, but something's probably gone wrong (maybe with an src somewhere?)
Edited convert.js to give us the random events, but the mapping still needs to be done. For now I'm just storing the raw data till we can convert the c# enums to a json map or something