Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python35 and Python36 to list of possible versions in windows. #63

Merged
merged 3 commits into from
Mar 13, 2017
Merged

Conversation

DeanF
Copy link
Contributor

@DeanF DeanF commented Aug 6, 2016

No description provided.

@DeanF DeanF changed the title Added Python35 and Python36 to list of possible versions in windows Added Python35 and Python36 to list of possible versions in windows. Jan 1, 2017
@DeanF DeanF changed the base branch from develop to master January 1, 2017 00:15
@DeanF DeanF changed the base branch from master to develop January 1, 2017 00:16
@@ -182,8 +182,8 @@ int InjectPythonCode(HANDLE hProcess, const char *code, char *moduleName)

int InjectPythonCodeToPID(DWORD pid, const char *code)
{
char versions[][9] = { "Python34", "Python33", "Python32", "Python31", "Python30", "Python27", "Python26", "Python25", "Python24" };
unsigned int numVersions = 9;
char versions[][9] = { "Python36", "Python35", "Python34", "Python33", "Python32", "Python31", "Python30", "Python27", "Python26", "Python25", "Python24" };
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the 9 need to be an 11 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the 9 refer to the length of each string?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, that makes sense.

* 'develop' of github.com:lmacken/pyrasite:
  Add the ability to control the IPC timeout.
@lmacken lmacken merged commit d0c90ab into lmacken:develop Mar 13, 2017
@lmacken
Copy link
Owner

lmacken commented Mar 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants