Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CI integration with codecov #17

Merged
merged 11 commits into from
Mar 25, 2020
Merged

Adds CI integration with codecov #17

merged 11 commits into from
Mar 25, 2020

Conversation

lmammino
Copy link
Owner

@lmammino lmammino commented Mar 23, 2020

Ref #14

Adds automated run of coverage after all tests are done and sends the report to codecov.

Example here: https://codecov.io/gh/lmammino/jwtinfo/branch/feature%2Fcoverage-reports

TODO

  • Add instructions on the readme on how to generate coverage reports manually
  • Try to bump coverage a bit

@lmammino lmammino added enhancement New feature or request test testing and coverage labels Mar 23, 2020
@lmammino lmammino self-assigned this Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0a2491d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   57.03%           
=========================================
  Files             ?        2           
  Lines             ?      128           
  Branches          ?       26           
=========================================
  Hits              ?       73           
  Misses            ?       29           
  Partials          ?       26           

@lmammino
Copy link
Owner Author

Trying kcov and rustcov as an alternative produces a slightly better result but still with a lot of false positives.

See attachment:
coverage-kcov.zip

Copy link
Collaborator

@stefanoabalsamo79 stefanoabalsamo79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Lu. Thanks

@lmammino lmammino merged commit 336a8ab into master Mar 25, 2020
@lmammino lmammino deleted the feature/coverage-reports branch March 25, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test testing and coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants