Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial multicolor support for 3 color displays #32

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

SaberShip
Copy link
Contributor

@SaberShip SaberShip commented Apr 16, 2023

I've done a quick implementation of "Accent Color" support for the 3 color e-paper displays.

Simply added a configuration for defining the accent color if DISP_3C is defined.
Updated display_utils to support setting color or using a default if not supplied.
I've modified the following elements to use the defined accent color:

  • The City/State
  • Currently Active Weather Warnings
  • Temperature Y-axis labels
  • Temperature Line Graph (Not the precip. chance bars)
  • BME Warning in status bar (if present)
  • WiFi signal status (if below configured threshold)
  • Battery status (if below configured threshold)
  • All fullscreen error icons

In the future it could be relatively simple to add more configurable color thresholds for current conditions (like UV, AQI, Visibility, etc...)

Below is an image of a 3 color display running under normal conditions:
IMG_20230415_191125

If required, I can upload more images showing different conditions with accent colors.

@lmarzen
Copy link
Owner

lmarzen commented Apr 18, 2023

@SaberShip I'll take a closer look this weekend if I have time and get back to you.

Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these additions look great, I just had two minor comments that must be addressed before merging.

platformio/src/renderer.cpp Outdated Show resolved Hide resolved
platformio/src/renderer.cpp Outdated Show resolved Hide resolved
@SaberShip
Copy link
Contributor Author

Of course!
Done.

@lmarzen lmarzen self-requested a review April 21, 2023 17:22
Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@lmarzen lmarzen merged commit 521d142 into lmarzen:main Apr 21, 2023
@lmarzen
Copy link
Owner

lmarzen commented Apr 21, 2023

Thank you for your contribution @SaberShip.

@lmarzen lmarzen added the enhancement New feature or request label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants