Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

tests from sdist not working #41

Closed
MuellerSeb opened this issue Feb 14, 2023 · 3 comments
Closed

tests from sdist not working #41

MuellerSeb opened this issue Feb 14, 2023 · 3 comments

Comments

@MuellerSeb
Copy link

Hi there,

the tests included in sdist are not working, since not all files are included and one gets the following error:

FileNotFoundError: [Errno 2] No such file or directory: 'tests/numpy_shapes.npz'
...
FileNotFoundError: [Errno 2] No such file or directory: 'tests/samples.json.gz'

So I think, these two files need to be included explicitly in the sdist.

Cheers,
Sebastian

@lmas
Copy link
Owner

lmas commented Feb 16, 2023 via email

lmas added a commit that referenced this issue Feb 18, 2023
When building sdist, ONLY THIS FILE will pull in extra data.
`package_data` in setup.py only works for bdist.
Source: https://stackoverflow.com/a/14159430
@lmas
Copy link
Owner

lmas commented Feb 18, 2023

@MuellerSeb I was unable to reproduce your issue, not sure what or how you tried to install the pkg.
At least #43 adds the test data to the sdist tarball when building. Can you confirm that works?

@lmas lmas closed this as completed in 2de2294 Apr 2, 2023
@lmas
Copy link
Owner

lmas commented Apr 2, 2023

Merging change and closing due to inactivity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants