Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language_column is not removed as expected #13

Closed
Anaphory opened this issue Jan 30, 2016 · 2 comments
Closed

language_column is not removed as expected #13

Anaphory opened this issue Jan 30, 2016 · 2 comments

Comments

@Anaphory
Copy link
Collaborator

I thought I had already adapted the code to remove the language_column from the data even when it is not called iso, but the issue is still there.

@lmaurits
Copy link
Owner

lmaurits commented Feb 1, 2016

I have changed the code which previously only removed "iso" from the data, and also added a test case for the "language_column" option (see tests/configs/nonstandard_lang_col.conf and tests/data/nonstandard_lang_col.csv). It seems to me that this is all working properly now. Can you please confirm that this is working for whatever data you were using when you opened this Issue?

@lmaurits
Copy link
Owner

lmaurits commented Feb 3, 2016

I'm assuming this is now fixed because the nonstandard_lang_col tests are passing fine, so I'm closing the issue. Please re-open if you find further problems.

@lmaurits lmaurits closed this as completed Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants