Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyYAML, an indirect dependency, needs Python>3.4 #253

Open
Anaphory opened this issue Jun 21, 2020 · 4 comments
Open

PyYAML, an indirect dependency, needs Python>3.4 #253

Anaphory opened this issue Jun 21, 2020 · 4 comments

Comments

@Anaphory
Copy link
Collaborator

The tests on my pull request #250 are failing for py34:

Collecting PyYAML>=3.01 (from pybtex->pycldf>=1.7->beastling==1.6.0.post0.dev0)
PyYAML requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.8

Do we drop 3.4 support or do we find a workaround, because actually we don't need the pybtex part of pycldf?

@Anaphory Anaphory changed the title PyYAML, an indirect dependency, needs Python>2.4 PyYAML, an indirect dependency, needs Python>3.4 Jun 22, 2020
@hugovk
Copy link

hugovk commented Jun 22, 2020

Sounds reasonable to drop it, Python 3.4 has been EOL since 2019-03-18, over a year ago:

@xrotwang
Copy link
Collaborator

Agree. dropping 3.4 seems ok. I'm still on 3.5, though :)

@lmaurits
Copy link
Owner

I'm happy to drop 3.4. I've just created .github/workflows/python-package.yml to begin migrating our testing away from Travis and toward GitHub. I've setup it up to only test 3.5 and later. There's no point in changing our Travis config, I guess (.travis.yml only specifies 3.5 and 3.6 anyway??), we can just delete the whole thing once the GitHub solution seems to be working smoothly. I'll leave this issue open until then as a reminder, but it doesn't seem to require any specific action on BEASTling's code proper.

@hugovk
Copy link

hugovk commented Jan 11, 2021

Could consider dropping 3.5 too, it's also now EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants