Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix situation with pruned trees and Random Local Clocks #54

Closed
lmaurits opened this issue Mar 13, 2016 · 1 comment
Closed

Fix situation with pruned trees and Random Local Clocks #54

lmaurits opened this issue Mar 13, 2016 · 1 comment

Comments

@lmaurits
Copy link
Owner

When using PrunedTrees/PrunedAlignments for datasets with lots of missing data, non-strict clock models need special treatment to ensure that everything still works correctly. Joseph has written a PrunedRelaxedClock class, and BEASTling uses this when appropriate. However, no PrunedRandomLocalClock class exists yet. We should (i) first change BEASTling to switch off PrunedTrees for analyses with RLCs (and inform the user), and (ii) sometime in the nearish future write the PrunedRandomLocalClock class and get it in BEASTLabs.

@lmaurits lmaurits added this to the 1.2.0 milestone Mar 15, 2016
@lmaurits
Copy link
Owner Author

I have implemented (i) above, i.e. pruned clocks are disabled for RLC analyses and the user is informed of this if using --verbose. (ii) is still something I would like to do, but it's not an urgent goal. I'm not going to close the issue, so that there is a reminder to do (ii) someday, but I am going to remove the 1.2.0 milestone because I think (i) alone is good enough to solve this for 1.2.0, as it will prevent people running flawed analyses.

@lmaurits lmaurits removed this from the 1.2.0 milestone Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant