When all commands were rejected, we should still process the response #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and not throw an exception
OndraM
requested review from
kubasimon,
davidkmenta,
foglcz,
jirinovak,
kdosiodjinud,
MortalFlesh,
hokypierce,
MarketaSebkova and
florianjiri
OndraM
force-pushed
the
feature/process-all-rejected-commands
branch
from
722cc61
to
efb985e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Matej API docs:
So from the API client point-of-view HTTP 400 is a "proper" response, which still should be processed and its data should be returned to the application (not causing an exception).