Update ECS, backport removed sniffs #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were deprecated in Symplify 7.2.20 and removed in Symplify 8.0
OndraM
changed the title
OndraM
requested review from
florianjiri,
hokypierce,
jirinovak,
kdosiodjinud,
legendik,
MarketaSebkova,
obelixicek,
janicekt and
dudla
|
How about mark those sniffs deprecated and consider to recommend |
legendik
approved these changes
Nov 27, 2020
|
@legendik I don't fell like opinionated "class naming" should be part of static analysis... While I understand AST (in PHPStan) is much better way how to achieve this check from implementation point of view (this was the main argument for the deprecation in ECS) , from "user" point of view it makes sense to have something like this in code style check. (If we have common phpstan rules, then yes, it could be moved there, but we don't. So I don't like to mark as deprecated something we use, it works and we don't have equivalent replacement.) |
jirinovak
approved these changes
Dec 1, 2020
kdosiodjinud
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards PHP 8 support.
In order to upgrade from ECS 7 to ECS 8, I've bacported sniffs removed in ECS 8 (which we use and want to keep using). Fixes #39 . (Sniffs original source: https://github.com/symplify/coding-standard/tree/v7.3.18/src/Sniffs/Naming )
But the ECS-upgrade journey continues, because ECS > 8.1.21 considers YAML config deprecated and forces you to use PHP config (deprecated-packages/symplify#2008) 😳 .