Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning raised when constructing lil_matrix #400

Closed
leriomaggio opened this issue Apr 11, 2020 · 1 comment
Closed

FutureWarning raised when constructing lil_matrix #400

leriomaggio opened this issue Apr 11, 2020 · 1 comment

Comments

@leriomaggio
Copy link
Collaborator

leriomaggio commented Apr 11, 2020

Description

Constructing a scipy.sparse.lil_matrix in UMAP.inverse_transform raises a FutureWarning

Versions

OS: macOS
Python 3.7.7 (default, Mar 26 2020, 10:32:53)
NumPy 1.17.5
SciPy 1.2.1
umap 0.4

Steps/Code to Reproduce

I put the code to reproduce the issue in this gist

Cause

This issue is caused by a backward incompatibility of scipy < 1.3 with the latest updates of Numpy (numpy>=1.17) APIs for broadcast_arrays.

scipy 1.3.1 fixes this issue: scipy/scipy#10379

Proposed solution

Looking at UMAP requirements.txt this is a perfectly valid combination of packages versions.

Due to the recent API changes in Numpy I would suggest to updates the requirements with most recent and non-conflicting numpy and scipy versions:

numpy>=1.17
scipy>=1.3.1
@lmcinnes
Copy link
Owner

Thanks -- good catch. I am not great at keeping up with the changing requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants