Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures with sklearn 1.2.0+ #962

Closed
mweinelt opened this issue Jan 28, 2023 · 0 comments
Closed

Test failures with sklearn 1.2.0+ #962

mweinelt opened this issue Jan 28, 2023 · 0 comments

Comments

@mweinelt
Copy link

mweinelt commented Jan 28, 2023

Hi, we (NixOS) are seeing some failures in the umap-learn 0.5.3 testsuite since upgrading past sklearn 1.2.0. Seems like a few places need to use asarray now to fix np.matrix usage. Actually similar to lmcinnes/pynndescent#207 and apparently fixed in c7d0568 and a714b59.

And then there is one other test, that seems to pass an unaccepted random_state apparently fixed in 949abd0.

sklearn.utils._param_validation.InvalidParameterError: The 'random_state' parameter of SpectralEmbedding must be an int in the range [0, 4294967295], an instance of 'numpy.random.mtrand.RandomState' or None. Got <module 'numpy.random' from '/nix/store/jirzlk538n9bbbwp54rd9wcsb8nf3rf0-python3.10-numpy-1.23.5/lib/python3.10/site-packages/numpy/random/init.py'> instead.

Both remain unrelased, but that is fine, we can apply them as patches to fix our downstream usage.

Edited, so others can maybe reuse this information.

full log

https://gist.github.com/mweinelt/e62e82595a30eeb79946d35131ecb970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant