notify email issue

[gulas2vladimir]

If is "My email" empty, never sends email to any "My contacts" addresses.
updated on views.py

# notify contacts
max_contacts = app.config['FLASKUP_MAX_CONTACTS']
    if 'mycontacts' in request.form and myemail:

to

# notify contacts
max_contacts = app.config['FLASKUP_MAX_CONTACTS']
    if 'mycontacts' in request.form:

[lmeunier]

Hi,

I don't see the benefit of this change. If you don't want to send emails to "My contacts", just don't fill the textarea... Or am I missing something?

[gulas2vladimir]

In my opinion, only be able options to send email about download lin without email from 'My email' template. Benefit of this is send email about download only. Delete link and other informations about shared file is not sometime interested because file will be deleted automatically.
Ok, it is only benefit for me;)
But if you interested about this options - Email template must by different because 'sender' variable is missing.

Thank you for your job. Very usefull simply applications.

On 29/05/14 09:16, Laurent Meunier wrote:

Hi,

I don't see the benefit of this change. If you don't want to send emails to "My contacts", just don't fill the textarea... Or am I missing something?

—
Reply to this email directly or view it on GitHub #3 (comment).

[lmeunier]

Ok, got it. I think it's fixed in commit 3e40ca9.

Before this commit, when a user leave 'My Email' empty and fill 'My Contacts' with some email addresses, no emails were sent. Now, emails are sent to contacts with a generic message : "Someone wants to share...".