Python Tutorial and PyTorch model added to train TMVA_RNN_Classification.C #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion.C We didn't had a PyTorch model to Train the RNN in TMVA similar to CNN, so here is the PyTorch Model with the Python tutorial for TMVA_RNN_Classification.C
|
Kindly review this PR then we can move it to Root repository if its fine. |
2 tasks
lmoneta
reviewed
May 6, 2022
| # CNN Model Definition | ||
| net = torch.nn.Sequential( | ||
| Reshape(), | ||
| nn.Conv2d(1, 10, kernel_size=3, padding=1), |
There was a problem hiding this comment.
It looks to me you are creating a CNN model instead of a RNN
| # CNN Model Definition | ||
| net = torch.nn.Sequential( | ||
| Reshape(), | ||
| nn.Conv2d(1, 10, kernel_size=3, padding=1), |
There was a problem hiding this comment.
It looks to me you are creating a CNN model instead of a RNN
| @@ -0,0 +1,308 @@ | |||
| import ROOT | |||
There was a problem hiding this comment.
The code should be integrated in the tutorial we are adding in the root-project#10442
| @@ -0,0 +1,308 @@ | |||
| import ROOT | |||
There was a problem hiding this comment.
The code should be integrated in the tutorial we are adding in the root-project#10442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't had a PyTorch model to Train the RNN in TMVA similar to CNN, so here is the improvement for the PyTorch Model with the Python tutorial for TMVA_RNN_Classification.C
This Pull request: Adds a PyTorch Model to Train the RNN in TMVA
Checklist: