Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Keep main clean and minor improvements #13

Merged
merged 12 commits into from
Jan 6, 2022
Merged

♻️ Keep main clean and minor improvements #13

merged 12 commits into from
Jan 6, 2022

Conversation

lmtani
Copy link
Owner

@lmtani lmtani commented Jan 6, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #13 (bf9d871) into main (fd50b4e) will increase coverage by 3.66%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   71.02%   74.68%   +3.66%     
==========================================
  Files          15       14       -1     
  Lines         497      478      -19     
==========================================
+ Hits          353      357       +4     
+ Misses         93       80      -13     
+ Partials       51       41      -10     
Impacted Files Coverage Δ
internal/commands/commands.go 100.00% <ø> (ø)
internal/commands/inputs.go 83.33% <ø> (ø)
internal/commands/kill.go 100.00% <ø> (ø)
internal/commands/navigate.go 60.81% <ø> (ø)
internal/commands/outputs.go 77.77% <ø> (ø)
internal/commands/submit.go 81.81% <ø> (ø)
internal/commands/wait.go 35.29% <ø> (ø)
pkg/cromwell/client.go 64.00% <73.46%> (+7.80%) ⬆️
pkg/output/writer.go 90.00% <87.50%> (+90.00%) ⬆️
internal/commands/cost.go 88.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd50b4e...bf9d871. Read the comment docs.

@lmtani lmtani merged commit f677b82 into main Jan 6, 2022
@lmtani lmtani deleted the refactoring branch January 6, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant