Refactoring for improvements #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabin-dongmo
commented
Sep 11, 2023
•
gabin-dongmo
commented
- Renamed CountryData to UserProfile
- Extracted SvgViewBox component
- Provided strong type for props in Card and PreviewCard
- Improved typing
- Extracted CardSocial component to improve readability
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Why change CountryData to UserProfile ? also, this amendment would update the #80 |
Because the interface refers conceptually to a user's profile instead of a country. Granted, we have profiles organized by countries, but they're still user profiles. Maybe a name different from UserProfile might resonate better... |
|
Okay, I understand better, thank @Sanix-Darker , could you give your opinion please? |
|
I realize I went ahead of myself and pushed changes without specifying the issues addressed. I will close this PR and introduce a proper issue to illustrate the changes suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.