Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LND Connect functionality for the App and Desktop version #26

Merged
merged 62 commits into from
Aug 26, 2019

Conversation

nolim1t
Copy link
Member

@nolim1t nolim1t commented Apr 28, 2019

This pull request closes #15

Usage

# Generates a LND connect string for ZAP App
# hostname port as localhost:10009
noma lnd lndconnectapp <hostname_and_port>

# Generates a LND connect string for ZAP Desktop
# hostname port as localhost:10009
noma lnd lndconnectstring <hostname_and_port>

@AnotherDroog AnotherDroog added the enhancement New feature or request label Apr 28, 2019
@AnotherDroog AnotherDroog self-assigned this Apr 28, 2019
@AnotherDroog AnotherDroog self-requested a review April 30, 2019 16:55
@AnotherDroog
Copy link
Member

I'm going to make some changes before merging

Copy link
Contributor

@ln2max ln2max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of hardcoded filesystem paths and lines that are much longer than 79 characters to me... fix is easy enough: instead of

def encodemacaroons(macaroonfile='/media/important/important/lnd/data/chain/bitcoin/mainnet/admin.macaroon', ...)

just do

MACAROON_FILE='/media/important/important/lnd/data/chain/bitcoin/mainnet/admin.macaroon'
def encode_macaroons(
    macaroonfile=MACAROON_FILE,
    ...
):

@AnotherDroog
Copy link
Member

It's producing strings but I can't get it to connect to Zap.

I've checked connectivity, and Zap connects to lnd manually when given the files.

The specification is here
https://github.com/LN-Zap/lndconnect/blob/master/lnd_connect_uri.md

Perhaps the base64 encoding is not being adhered to properly?

2 similar comments
@AnotherDroog
Copy link
Member

It's producing strings but I can't get it to connect to Zap.

I've checked connectivity, and Zap connects to lnd manually when given the files.

The specification is here
https://github.com/LN-Zap/lndconnect/blob/master/lnd_connect_uri.md

Perhaps the base64 encoding is not being adhered to properly?

@AnotherDroog
Copy link
Member

It's producing strings but I can't get it to connect to Zap.

I've checked connectivity, and Zap connects to lnd manually when given the files.

The specification is here
https://github.com/LN-Zap/lndconnect/blob/master/lnd_connect_uri.md

Perhaps the base64 encoding is not being adhered to properly?

@nolim1t
Copy link
Member Author

nolim1t commented Aug 22, 2019

is the hostname correct? Is the tls certificate valid for that hostname?

noma/lnd.py Outdated Show resolved Hide resolved
@AnotherDroog AnotherDroog mentioned this pull request Aug 23, 2019
2 tasks
@AnotherDroog
Copy link
Member

Done. Use noma lnd connectstring to get the url to your lnd wallet

@AnotherDroog AnotherDroog merged commit 6c0a823 into lncm:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation Issues enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zapconnect functionality
3 participants