Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unspecified response in case of invalid request #6

Closed
Kixunil opened this issue Jun 25, 2019 · 3 comments
Closed

Unspecified response in case of invalid request #6

Kixunil opened this issue Jun 25, 2019 · 3 comments

Comments

@Kixunil
Copy link
Contributor

Kixunil commented Jun 25, 2019

The specification doesn't describe what response should be at step 2 when there's an error - e.g. the secret is invalid. Should there be specific JSON body or just HTTP error? Which HTTP error?
@akumaigorodski
Copy link
Collaborator

Currently the only client implementation (BLW) awaits for a valid Json as a response there and shows a raw error dump if anything goes wrong (Json could not be parsed, non-200 status code etc). Perhaps we can use a scheme similar to .6 there ({"status":"ERROR", "reason":"error details..."}), what do you think?

@akumaigorodski
Copy link
Collaborator

I've updated both BLW and spec according to my above proposal for now.

Kixunil added a commit to Kixunil/lnch-vekslak that referenced this issue Jun 27, 2019
@Kixunil
Updated invalid secret error handling
2ab913f 
The error handling wasn't specified before. Now the specification
updated to include it, so this code was changed accordingly.

See lnurl/luds#6
@Kixunil
Copy link
Contributor Author

Kixunil commented Jun 27, 2019

Yeah, that works for me well. I've updated lnch-vekslak.

@Kixunil Kixunil closed this as completed Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kixunil @akumaigorodski