feat: start influxdb with test runs #39
Conversation
Add's an influx_options to the plan to choose whether to create an InfluxDB container instance and populate its IP to the plan for later setup of telegraf. Can also be optionally torn down at the end of the test run. Closes #19
| # We have to exclude it from the services discovered above if we | ||
| # should NOT tear it down | ||
| if not self._plan["influx_options"]["tear_down"]: | ||
| metric_service = self.locate_metrics_service() |
There was a problem hiding this comment.
Do we need to fetch service_arns here (actually for any service)? If create_service returns them couldn't we carry them around in the lambda step state for later use here?
There was a problem hiding this comment.
The metric service may already be running, so it wouldn't have been created at startup. Since shut-down needs to catch errors in other sections, service arn's or other info may be missing in the JSON blob passed around. So shut-down assumes nothing, and queries AWS to see what's there.
| "logDriver": "awslogs", | ||
| "options": { | ||
| "awslogs-group": self.container_log_group, | ||
| "awslogs-region": "us-east-1", |
There was a problem hiding this comment.
Probably want region to be configurable
There was a problem hiding this comment.
ardere is currently confined to us-east-1. There's a few ECS related reasons for this, like the fact that ECS seems to have clusters in a specific region, you can choose AZ's, but not regions. So at the moment, all of ardere is us-east-1 only.
Add's an influx_options to the plan to choose whether to create an
InfluxDB container instance and populate its IP to the plan for later
setup of telegraf. Can also be optionally torn down at the end of the
test run.
Closes #19