Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix effect parsing #7

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Fix effect parsing #7

merged 2 commits into from
Dec 15, 2021

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Dec 15, 2021 •
edited
Loading

Description

Deals with changes in mafia r26000 (but requires r26002 to work)

Fixes #5

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based by pull request against the main branch or have a good reason not to.

@gausie gausie requested a review from soolar December 15, 2021 12:14
@gausie gausie mentioned this pull request Dec 15, 2021
Closed
Rinn
Rinn approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@Rinn Rinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I pulled the branch and it fixes the effects parsing.

@soolar soolar merged commit ad62038 into main Dec 15, 2021
@soolar soolar deleted the effects-parsing branch December 15, 2021 20:08
@soolar
Copy link
Member

soolar commented Dec 15, 2021

Thanks a bunch!

@gausie gausie mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rinn Rinn Rinn approved these changes

@soolar soolar Awaiting requested review from soolar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Effects list does not display anything
3 participants
@gausie @soolar @Rinn