Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates #26

Merged
merged 3 commits into from
Aug 29, 2017
Merged

Various updates #26

merged 3 commits into from
Aug 29, 2017

Conversation

robinjoseph08
Copy link
Contributor

@robinjoseph08 robinjoseph08 commented Aug 28, 2017 •
edited
Loading

What & Why

Update various parts of this repo since it's been getting more contributions lately. The changes include:

  • Update eslint-config-lob so that all of our newer lint rules are present
  • Update the .npmignore to ignore more unnecessary files

@robinjoseph08 robinjoseph08 changed the title Various updates [WIP] Various updates Aug 28, 2017
@robinjoseph08 robinjoseph08 changed the title [WIP] Various updates Various updates Aug 29, 2017
dmlittle
dmlittle approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@dmlittle dmlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlittle dmlittle assigned robinjoseph08 and unassigned dmlittle Aug 29, 2017
@robinjoseph08 robinjoseph08 merged commit e41c7ae into master Aug 29, 2017
@robinjoseph08 robinjoseph08 deleted the update branch August 29, 2017 01:18
@robinjoseph08 robinjoseph08 mentioned this pull request Aug 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlittle dmlittle dmlittle approved these changes

Assignees

@robinjoseph08 robinjoseph08

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinjoseph08 @dmlittle