PP-225: Hapi v17, Node.js v14, update deps, nyc coverage, modernize #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tlhunter
commented
Aug 31, 2021
•
tlhunter
commented
- update packages
- istanbul to nyc
- test on Node.js v14
- Hapi v17 compatibility
- updated linter rules
- SemVer MAJOR change
tlhunter
changed the title
tlhunter
changed the title
Lianathanoj
reviewed
Aug 31, 2021
.gitignore
Outdated
| @@ -11,7 +11,7 @@ pids | |||
| lib-cov | |||
|
|
|||
| # Coverage directory used by tools like istanbul | |||
There was a problem hiding this comment.
super nit: if we're deprecating istanbul, we can say nyc instead
Lianathanoj
reviewed
Aug 31, 2021
.node-version
Outdated
| 14.15.5 |
There was a problem hiding this comment.
i believe some of our main repos are in 14.17.0 now, so we can bump this up a bit more
Lianathanoj
reviewed
Aug 31, 2021
| exports.register.attributes = { | ||
| name: 'hapi-rate-limiter' | ||
| }; | ||
| exports.pkg = require('../package.json'); |
There was a problem hiding this comment.
you can also specify exports.name = 'hapi-rate-limiter' if you want parity
There was a problem hiding this comment.
the .pkg.name and .pkg.version get hoisted up to .name and .version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.